[#504] Keep editor bars from covering content#505
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #505 on live head 768afb765819498ad6eac9b0a95ee9bf1ac65a08. The fix matches issue #504: the story workspace now allocates a real flex-1 min-h-0 slot for the active panel, and the prose editor save bar plus bottom footer are rendered as reserved rows instead of overlaying the editor body.
Findings
- No blocking findings.
Decision
Approved on GitHub. The structural layout changes in StoriesPage and PreviewPanel are scoped to the right-hand story workspace, and the new Genesis regression test exercises the reported Preview -> Edit -> Cuts -> Opening text -> Preview switching path. Live lint-and-typecheck was still pending during review, so merge should still use the current live head/check state.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
PR #505 fixes the reported cartoon prose-editor overlap by giving the right workspace and PreviewPanel editor a proper min-h-0 flex stack, keeping the save/status bar and bottom footer as non-shrinking rows outside the editor scroll body. The added regression test exercises the Genesis opening-text Edit/Cuts/Preview switching path that triggered the bug.
Findings
- No blocking findings.
Decision
Approved on GitHub for commit 768afb765819498ad6eac9b0a95ee9bf1ac65a08. Live lint-and-typecheck passes, and the implementation is scoped to the affected cartoon/right-panel layout plus rebuilt dist artifacts.
Closes #504.
Summary
flex-1 min-h-0content slot so Preview/Edit pages recalculate correctly after tab and route switchesVerification
npm run typechecknpm run lint -- --quiet app/web/components/StoriesPage.tsx app/web/components/PreviewPanel.tsx app/web/components/PreviewPanel.test.tsxnpm run app:buildUnknown system error -122, write, includingnpx vitest run --coverage.enabled=false app/web/components/PreviewPanel.test.tsxVisual / Viewport QA Notes
flex-1 min-h-0wrapper inStoriesPage, so top workflow/nav strips and bottom publish/error strips reserve height instead of forcing the editor to overrun the columnPreviewPanelis nowoverflow-hiddenwith a dedicated non-shrinking save/status row, and the bottom episode footer is also a non-shrinking sibling with its own backgroundPreview -> Edit -> Cuts -> Opening text -> Previewtwice and asserts both the editor save bar and the footer remain present as separate chromeRisks
h-fullsizing